Adding OAuth support for SnowflakeHook #47191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:snowflake
sunank200
approved these changes
Feb 28, 2025
bugraoz93
approved these changes
Feb 28, 2025
potiuk
force-pushed
the
snowflake_hook_oauth
branch
from
2d0db9d to
fe00766
Compare
Member
|
Rebased. This one looks good to merge if the questions are resolved @sunank200 ? |
potiuk
approved these changes
Apr 9, 2025
mik-laj
approved these changes
Apr 12, 2025
potiuk
approved these changes
Apr 17, 2025
Member
|
Needs to be rebased again. Can you please rebase? @Sharashchandra |
Sharashchandra
force-pushed
the
snowflake_hook_oauth
branch
from
ef2205e to
cad0203
Compare
Contributor
Author
|
@potiuk rebased! |
bugraoz93
force-pushed
the
snowflake_hook_oauth
branch
from
cad0203 to
60d1f13
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Contributor
|
Congrats @Sharashchandra! 🎉 |
Member
|
@Sharashchandra cant we merge |
This was referenced May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the SnowflakeHook in the Airflow repo by completing the OAuth authentication flow. It adds logic to fetch the access token using the refresh_token, client_id, and client_secret, which are already managed in the extras of the Snowflake connection object.
Changes & Fixes:
Implements logic to exchange the refresh_token for a new access token before establishing a connection.
Resolves an issue where using refresh_token, client_id, and client_secret directly with SnowflakeHook results in the error:
main/newsfragments).
Duplicate of #47073, Reopening because I messed up the updates